Skip to content

Fix bridge choice for non-Float64 #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix bridge choice for non-Float64 #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31e1e2b
Fix bridge choice for non-Float64
blegat Jun 4, 2024
0fd1559
Fix
blegat Jun 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 19 additions & 12 deletions src/constraints.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,24 +293,24 @@ function JuMP.moi_set(
end

function PolyJuMP.bridges(
::Type{<:MOI.AbstractVectorFunction},
F::Type{<:MOI.AbstractVectorFunction},
::Type{EmptyCone},
)
return [(Bridges.Constraint.EmptyBridge, Float64)]
return Tuple{Type,Type}[(Bridges.Constraint.EmptyBridge, PolyJuMP.coefficient_type_or_float(F))]
end

function PolyJuMP.bridges(
::Type{<:MOI.AbstractVectorFunction},
F::Type{<:MOI.AbstractVectorFunction},
::Type{PositiveSemidefinite2x2ConeTriangle},
)
return [(Bridges.Constraint.PositiveSemidefinite2x2Bridge, Float64)]
return Tuple{Type,Type}[(Bridges.Constraint.PositiveSemidefinite2x2Bridge, PolyJuMP.coefficient_type_or_float(F))]
end

function PolyJuMP.bridges(
::Type{<:MOI.AbstractVectorFunction},
F::Type{<:MOI.AbstractVectorFunction},
::Type{<:DiagonallyDominantConeTriangle},
)
return [(Bridges.Constraint.DiagonallyDominantBridge, Float64)]
return Tuple{Type,Type}[(Bridges.Constraint.DiagonallyDominantBridge, PolyJuMP.coefficient_type_or_float(F))]
end

function PolyJuMP.bridges(
Expand All @@ -333,23 +333,30 @@ function PolyJuMP.bridges(
)]
end

function _bridge_coefficient_type(
T::Type,
::Type{SOSPolynomialSet{S,B,C}},
) where {S,B,C}
return _complex(T, matrix_cone_type(C))
end

function PolyJuMP.bridges(
::Type{<:MOI.AbstractVectorFunction},
F::Type{<:MOI.AbstractVectorFunction},
S::Type{<:SOSPolynomialSet{<:AbstractAlgebraicSet}},
)
return Tuple{Type,Type}[(
Bridges.Constraint.SOSPolynomialBridge,
_bridge_coefficient_type(S),
_bridge_coefficient_type(PolyJuMP.coefficient_type_or_float(F), S),
)]
end

function PolyJuMP.bridges(
::Type{<:MOI.AbstractVectorFunction},
F::Type{<:MOI.AbstractVectorFunction},
S::Type{<:SOSPolynomialSet{<:BasicSemialgebraicSet}},
)
return [(
return Tuple{Type,Type}[(
Bridges.Constraint.SOSPolynomialInSemialgebraicSetBridge,
_bridge_coefficient_type(S),
_bridge_coefficient_type(PolyJuMP.coefficient_type_or_float(F), S),
)]
end

Expand Down Expand Up @@ -462,7 +469,7 @@ function JuMP.build_constraint(
_coefs = PolyJuMP.non_constant(__coefs)
# If a polynomial with real coefficients is used with the Hermitian SOS
# cone, we want to promote the coefficients to complex
T = _bridge_coefficient_type(typeof(set))
T = _bridge_coefficient_type(JuMP.value_type(JuMP.variable_ref_type(eltype(_coefs))), typeof(set))
coefs = convert(Vector{_promote_coef_type(eltype(_coefs), T)}, _coefs)
shape = PolyJuMP.PolynomialShape(basis)
return PolyJuMP.bridgeable(
Expand Down
2 changes: 1 addition & 1 deletion src/variables.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,6 @@ function JuMP.add_variable(
JuMP.VariableRef[JuMP.VariableRef(model, vi) for vi in Q],
v.p.basis,
MCT,
Float64,
JuMP.value_type(typeof(model)),
)
end
Loading