Skip to content

handling exp default value, if exp comes from claims #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

handling exp default value, if exp comes from claims #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47ae96e
handling exp default value, if exp comes from claims
patoi Sep 8, 2016
23f0028
claims.exp is seconds not ms
patoi Sep 8, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,9 +431,9 @@ var jwtLib = {
jwt.setSigningAlgorithm(args.length===3 ? alg : 'HS256');
jwt.setSigningKey(secret);
}
jwt.setExpiration((nowEpochSeconds() + (60*60))*1000); // one hour
jwt.setExpiration(claims.exp * 1000 || (nowEpochSeconds() + (60 * 60)) * 1000);
return jwt;
}
};

module.exports = jwtLib;
module.exports = jwtLib;
9 changes: 6 additions & 3 deletions test/builder.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,12 @@ describe('create()',function(){
assert.equal(nJwt.create({},uuid()).body.exp , oneHourFromNow);
});

it('should not create default exp field, if exp is given',function(){
var time = Math.floor(Date.now()/1000)
var token = nJwt.create({exp: time},uuid())
assert.equal(token.body.exp , time);
});

it('should not overwrite a defined jti field',function(){
assert.equal(nJwt.create({jti: 1},uuid()).body.jti , 1);
});
Expand Down Expand Up @@ -108,6 +114,3 @@ describe('base64 URL Encoding',function(){

});
});