Skip to content

Conversation

@SimonTheLeg
Copy link
Contributor

@SimonTheLeg SimonTheLeg commented Oct 8, 2025

This is required since functions like sha3 short expect a string to work properly and not the custom type

Summary

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes #

Release Notes

Fix: ClusterName and ClusterPath can now be used in conjunction with sha3short template function 

This is required since functions like sha3 short expect a string to
work properly and not the custom type
@kcp-ci-bot kcp-ci-bot added kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the DCO. labels Oct 8, 2025
@SimonTheLeg SimonTheLeg requested review from embik and xrstf October 8, 2025 08:37
@kcp-ci-bot kcp-ci-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 8, 2025
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 8, 2025
@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b4f8a5da61efb3a61a5bdcdfc3e9e2a5abdac8a8

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2025
@embik
Copy link
Member

embik commented Oct 8, 2025

/cherry-pick release-0.4

@kcp-ci-bot
Copy link
Contributor

@embik: once the present PR merges, I will cherry-pick it on top of release-0.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 8, 2025
@SimonTheLeg
Copy link
Contributor Author

/retest

1 similar comment
@xrstf
Copy link
Contributor

xrstf commented Oct 8, 2025

/retest

@kcp-ci-bot kcp-ci-bot merged commit 1791023 into kcp-dev:main Oct 8, 2025
10 checks passed
@kcp-ci-bot
Copy link
Contributor

@embik: new pull request created: #107

In response to this:

/cherry-pick release-0.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has signed the DCO. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants