Create base/default contexts in kubeconfigs and extend samples #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On-behalf-of: @SAP [email protected] Signed-off-by: Marvin Beckers <[email protected]>
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
kcp-ci-bot
added
kind/feature
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
embik
force-pushed
the
kubeconfigs-contexts
branch
from
d3dd639 to
e0e2999
Compare
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
embik
changed the title
kcp-ci-bot
removed
the
do-not-merge/work-in-progress
On-behalf-of: SAP <[email protected]> Signed-off-by: Marvin Beckers <[email protected]>
|
/retest looks like a flake for etcd setup? |
|
LGTM label has been added. Git tree hash: 51715b368591e5e1fb721094df5b320dd718feda
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xrstf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kcp-ci-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated version of #47, adding some more fields to sample objects in
config/samplesand newKubeconfigobjects for specific target references.This continues some of the work started in #47, namely aligning kubeconfig context names with what the kcp e2e tests (not part of this PR for now) expect (
default/base/shard-base). It also extends the samples given inconfig/sampleswith more annotated objects useful when getting started with the operator.What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes #
Release Notes