Skip to content

add -i flag to workspace command #3611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

add -i flag to workspace command #3611

merged 1 commit into from
Oct 28, 2025

Conversation

@olamilekan000
Copy link
Contributor

@olamilekan000 olamilekan000 commented Oct 1, 2025 •
edited
Loading

Summary

change adds the -i and --interactive  flags to the workspace command
inorder to view workspaces in an interactive mode.
image

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #
#3098

Release Notes

Added --i and --interactive flags to the workspace command for exploring and managing workspaces interactively.

@kcp-ci-bot kcp-ci-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Indicates the PR's author has signed the DCO. area/cli Issues or PRs related to CLI changes size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2025
@kcp-ci-bot
Copy link
Contributor

Hi @olamilekan000. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@olamilekan000 olamilekan000 force-pushed the add-interactive-ws-interactive-mode branch 6 times, most recently from 21b32a8 to 457cd7b Compare October 1, 2025 21:09
@mjudeikis
Copy link
Contributor

mjudeikis commented Oct 3, 2025 •
edited
Loading

Just wondering, have you ever tried https://github.com/charmbracelet/bubbletea?
We had a discussion a long time ago about whether this might be one we would want to go with.
Wondering how much effort would be to convert to this?

Another node - would be good to have some indication when node is collapsed. like + at the front or back, to indicate that there are leafs available.

@olamilekan000
Copy link
Contributor Author

ust wondering, have you ever tried https://github.com/charmbracelet/bubbletea? We had a discussion a long time ago about whether this might be one we would want to go with. Wondering how much effort would be to convert to this?

Another node - would be good to have some indication when node is collapsed. like + at the front or back, to indicate that there are leafs available.

No, I haven't tried it before. But looking at it, they share similar design pattern, so I guess it shouldn't take much effort.

Another node - would be good to have some indication when node is collapsed. like + at the front or back, to indicate that there are leafs available.

Okay, Noted.

@olamilekan000
Copy link
Contributor Author

olamilekan000 commented Oct 5, 2025 •
edited
Loading

Another node - would be good to have some indication when node is collapsed. like + at the front or back, to indicate that there are leafs available.

"▶ " and "▼ " looks better. I'll be going with them. @mjudeikis

@olamilekan000 olamilekan000 force-pushed the add-interactive-ws-interactive-mode branch from 457cd7b to d03cbf8 Compare October 5, 2025 00:52
@kcp-ci-bot kcp-ci-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 5, 2025
@olamilekan000 olamilekan000 force-pushed the add-interactive-ws-interactive-mode branch from d03cbf8 to 285b291 Compare October 5, 2025 00:56
@olamilekan000
Copy link
Contributor Author

/retest

1 similar comment
@olamilekan000
Copy link
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 7, 2025
@olamilekan000 olamilekan000 requested review from gman0 and xrstf October 7, 2025 01:20
@olamilekan000 olamilekan000 force-pushed the add-interactive-ws-interactive-mode branch from 285b291 to c412957 Compare October 7, 2025 01:25
@mjudeikis
Copy link
Contributor

/retest

@mjudeikis
Copy link
Contributor

@olamilekan000 fialures looks either wrong version of deps? can you check if version really exists?

@mjudeikis
Copy link
Contributor

/retest
CI Cache is having a bad day?

@olamilekan000 olamilekan000 force-pushed the add-interactive-ws-interactive-mode branch from 3ce55f6 to 2261d87 Compare October 12, 2025 21:53
@olamilekan000
Copy link
Contributor Author

/retest

1 similar comment
@mjudeikis
Copy link
Contributor

/retest

@mjudeikis
Copy link
Contributor

/retest
checking proxy inself

@mjudeikis mjudeikis mentioned this pull request Oct 14, 2025
Closed
@olamilekan000
Copy link
Contributor Author

/retest

@olamilekan000 olamilekan000 force-pushed the add-interactive-ws-interactive-mode branch 12 times, most recently from 285853f to 3e27cdc Compare October 28, 2025 05:05
mjudeikis
mjudeikis reviewed Oct 28, 2025
View reviewed changes
@olamilekan000
add -i flag to workspace command
9be523f 
Signed-off-by: olalekan odukoya <[email protected]>
@olamilekan000 olamilekan000 force-pushed the add-interactive-ws-interactive-mode branch from 3e27cdc to 9be523f Compare October 28, 2025 07:44
mjudeikis
mjudeikis approved these changes Oct 28, 2025
View reviewed changes
Copy link
Contributor

@mjudeikis mjudeikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kcp-ci-bot kcp-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2025
@kcp-ci-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 466c983ee5502fbe6a44733942806becb4ce8a18

@kcp-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjudeikis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2025
@olamilekan000
Copy link
Contributor Author

/retest

@kcp-ci-bot kcp-ci-bot merged commit a27a107 into kcp-dev:main Oct 28, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjudeikis mjudeikis mjudeikis approved these changes

@gman0 gman0 Awaiting requested review from gman0

@xrstf xrstf Awaiting requested review from xrstf

Assignees

@mjudeikis mjudeikis

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Issues or PRs related to CLI changes dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olamilekan000 @kcp-ci-bot @mjudeikis