-
Notifications
You must be signed in to change notification settings - Fork 62
Implement runtime-configurable Grafana endpoints and database names #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If we want to support this in a Kubeflow deployment we'll need to add it to the manifests |
1c5bef3
to
23a15d1
Compare
yes, all the configuration should be exposed in kustomize with the default values. |
Signed-off-by: Harshit Nayan <[email protected]> updated README with grafana config Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Harshit Nayan <[email protected]>
Signed-off-by: Harshit Nayan <[email protected]>
e0d232f
to
b777a57
Compare
After we merge we need to update the website to include the environment variables. See table in https://www.kubeflow.org/docs/components/kserve/webapp/#install-standalone |
Please ping me when you need a merge |
Signed-off-by: Harshit Nayan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juliusvonkohout looks good to me
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
Signed-off-by: Julius von Kohout <[email protected]>
fixes: #6
The changes add runtime-configurable Grafana support:
The backend reads new env vars (GRAFANA_PREFIX, GRAFANA_CPU_MEMORY_DB, GRAFANA_HTTP_REQUESTS_DB) and exposes them via a new /api/config endpoint; the frontend adds a ConfigService (with APP_INITIALIZER) to load that config at startup and updates GrafanaService, ServerInfoComponent and MetricsComponent to use the runtime values with robust fallbacks and error handling.
Tested it by running models web app with: