Skip to content

Conversation

@Xilonz
Copy link

@Xilonz Xilonz commented Oct 28, 2024

Because: #252

@netlify
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for lando-core ready!

Name Link
🔨 Latest commit 137e791
🔍 Latest deploy log https://app.netlify.com/sites/lando-core/deploys/67364a8c78ce0400079c8ad6
😎 Deploy Preview https://deploy-preview-257--lando-core.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 93 (🔴 down 2 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (no change from production)
SEO: 98 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@reynoldsalec reynoldsalec requested a review from pirog October 28, 2024 17:31
@reynoldsalec
Copy link
Member

I'm comfortable with this, @pirog does it pass your smell test? Know it seems a little edge case-y but want to encourage people to be making plugins obviously, no matter if a keyword attribute is available in their code repository's API output :)

@Xilonz could you resolve the code linting errors and add documentation.

Would be ideal to have a test, could probably just target a repo that's an NPM package (but not a Lando plugin) and have it try to download that with the --force option.

@Xilonz
Copy link
Author

Xilonz commented Nov 15, 2024

@reynoldsalec Just noticed that package installs from tar.gz's are supported as well (its not in the docs tough). Is that planned to stay as a feature? If so, there's probably enough methods available to install a package to suit everyone's needs.

The only disadvantage I see is that when using tar.gz (and .git?), is that it has to be a build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants