Fix exception deprecation notice #59
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspencer244
commented
Jun 30, 2025
| $this->code = $code ?? $response->getStatusCode(); | ||
| parent::__construct($message, $code ?? $response->getStatusCode()); | ||
|
|
||
| parent::__construct($message, $code); |
There was a problem hiding this comment.
A deprecation notice was emitted If $code is null here.
tspencer244
commented
Jun 30, 2025
| { | ||
| parent::setUp(); | ||
|
|
||
| $this->withoutDeprecationHandling(); |
There was a problem hiding this comment.
This configures Laravel to let deprecation notices bubble up to the PHPUnit error handler.
Fixed the following deprecation notice: "Exception::__construct(): Passing null to parameter laravel-notification-channels#2 ($code) of type int is deprecated"
tspencer244
force-pushed
the
fix-exception-deprecation-notice
branch
from
78c3ed2 to
98e724e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the following deprecation notice:
"Exception::__construct(): Passing null to parameter #2 ($code) of type int is deprecated"