Skip to content

Passed all tests #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Passed all tests #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,29 @@
function scuberGreetingForFeet(){
function scuberGreetingForFeet(feet){
// Write your code here!
if(feet <= 400){
return 'This one is on me!'
} else if(feet >400 && feet < 2000){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can exclude feet > 400 && since it's already covered by the first part of the conditional.

return 'That will be twenty bucks.';
} else if(feet > 2000 && feet <= 2500){
return 'I will gladly take your thirty bucks.'
} else if(feet > 2500){
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same idea here.

Suggested change
} else if(feet > 2500){
} else {

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I guess I'm not that comfortable yet with the flow so I'm being redundant.

return 'No can do.'
}
}

function ternaryCheckCity(){
function ternaryCheckCity(city){
// Write your code here!
return city === 'NYC' ? 'Ok, sounds good.' : 'No go.'
}

function switchOnCharmFromTip(){
function switchOnCharmFromTip(tip){
// Write your code here!
switch(tip){
case 'generous':
return 'Thank you so much.'
case 'not as generous':
return 'Thank you.'
default:
return 'Bye.'
}
}