fix: correct spelling of 'negotiate_timeout' in multiple files #909
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Issue #908
There was a widespread typo in the codebase where the parameter name
negotitate_timeout
was used instead of the correctnegotiate_timeout
. This typo appeared in multiple files and created inconsistency in the API, making the codebase harder to understand and maintain.The typo affected:
How was it fixed?
Systematically renamed all instances of
negotitate_timeout
tonegotiate_timeout
across the affected files to maintain consistency with:multiselect.py
DEFAULT_NEGOTIATE_TIMEOUT
used throughout the codebaseFiles modified:
py-libp2p/libp2p/protocol_muxer/multiselect_client.py
- Fixed parameter definitions inselect_one_of
andselect_protocol_or_fail
methodspy-libp2p/libp2p/__init__.py
- Fixed parameter definition innew_node
functionpy-libp2p/libp2p/host/basic_host.py
- Fixed parameter usage in method calls toselect_one_of
The fix ensures that:
To-Do
Cute Animal Picture