-
Notifications
You must be signed in to change notification settings - Fork 182
health monitoring #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
health monitoring #915
Conversation
Hi @seetadev this ci keeps failing but has nothing to do with the implementation i made, and also i had to create a new pr because there was a lot of changes that affected me when i git pulled |
Hello @sumanjeet0012 @lla-dane @sukhman-sukh please can i get a review on this, thanks |
@bomanaps Could you please share the link to the specification file or a reference to this feature in other libp2p implementations? It would be easier for me to understand what exactly we want to implement through this PR. |
|
@acul71 i had to create a new pr because there was a lot of changes that affected me when i git pulled |
Hello @acul71 @sumanjeet0012 @lla-dane @sukhman-sukh please can i get a review on this, thanks |
@bomanaps This is a fairly substantial PR, and there have already been extensive discussions surrounding it. I’ll need some additional time to review it thoroughly. I’m planning to go through it over the weekend. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bomanaps Would you be able to share a basic screencast demonstrating the execution of health_monitoring_example.py? I'm currently facing some issues with dependency installation and haven't been able to run the example locally.
@bomanaps 🎉 Conclusion |
Hello @acul71 @sumanjeet0012 @seetadev am done addressing this Screen.Recording.2025-09-17.at.07.53.50.mov |
Hey. Good try, but It's difficult to understands what's going on, without audio that comments over or subs or another format like presentation with slides Isn't there something like a panel with real time info or something like that Kidding, just something more clear at a glance |
@bomanaps Are the failing test related or not ? do they fail on your local box with |
If we can re run the ci that will be good the logs iis not from my end make pr passes too, but the ci fail is showing test_provide_and_find_providers is checking that envelope_a |
@sumanjeet0012 LGTM see if you dig it. |
What was wrong?
Issue #
How was it fixed?
Comprehensive Health Metrics: Implemented ConnectionHealth dataclass with latency tracking, success rates, bandwidth monitoring, and weighted health scoring.
Proactive Monitoring Service: Built ConnectionHealthMonitor with periodic health checks, real-time ping measurements, and automatic unhealthy connection replacement.
Health-Aware Load Balancing: Added four intelligent connection selection strategies, including health_based and latency_based, for optimal traffic routing.
API Consistency Fix: Extended new_host() to accept connection_config, resolving previous API inconsistency while maintaining full backward compatibility.
Summary of approach.
To-Do
Cute Animal Picture