Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Fixes Issue #962 :
KAD-DHT tests became ~33% slower (from sub-1s to ~1.66s) after PR #892's security fix that changed bind address from
0.0.0.0
to127.0.0.1
—specifically affected thetest_provide_and_find_providers
test.How was it fixed?
Implemented configurable bind addresses through
LIBP2P_BIND
environment variable while keeping127.0.0.1
as secure default:This provides:
To-Do