Skip to content

fix: tuple unpacking and tx params #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: tuple unpacking and tx params #472

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions scripts/_vote_2025_MM_DD.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
# ================================ Main ======================================
def get_vote_items() -> Tuple[List[str], List[Tuple[str, str]]]:


# TODO in case of using smart-contract based omnibus, retrieve vote items from omnibus contract
# voting_items = brownie.interface.SmartContractOmnibus(omnibus_contract).getVoteItems()
# vote_desc_items = []
Expand Down Expand Up @@ -70,7 +69,7 @@ def get_vote_items() -> Tuple[List[str], List[Tuple[str, str]]]:


# TODO return vote_desc_items, call_script_items
pass
return [], []


def start_vote(tx_params: Dict[str, str], silent: bool = False):
Expand All @@ -82,9 +81,8 @@ def start_vote(tx_params: Dict[str, str], silent: bool = False):
if silent else upload_vote_ipfs_description(IPFS_DESCRIPTION)
)

vote_id, tx = confirm_vote_script(vote_items, silent, desc_ipfs) and list(
create_vote(vote_items, tx_params, desc_ipfs=desc_ipfs)
)
confirm_vote_script(vote_items, silent, desc_ipfs)
vote_id, tx = create_vote(vote_items, tx_params, desc_ipfs=desc_ipfs)

return vote_id, tx

Expand All @@ -102,7 +100,7 @@ def start_and_execute_vote_on_fork_manual():
if get_is_live():
raise Exception("This script is for local testing only.")

tx_params = {"from": get_deployer_account()}
tx_params = {"from": get_deployer_account().address}
vote_id, _ = start_vote(tx_params=tx_params, silent=True)
print(f"Vote created: {vote_id}.")
pass_and_exec_dao_vote(int(vote_id), step_by_step=True)