-
Notifications
You must be signed in to change notification settings - Fork 706
hack/test-port-forwarding.pl: support socat
as listener and writer
#4170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hack/test-port-forwarding.pl: support socat
as listener and writer
#4170
Conversation
fe0fed9
to
c18012f
Compare
As far as I can see, tests that failed in |
76487b1
to
a8100de
Compare
I'm just browsing, but this PR still has failing port forwarding tests, e.g. https://github.com/lima-vm/lima/actions/runs/18364708138/job/52315306508?pr=4170. So it looks like switching to |
This PR does tests using both of |
I guessed that the reason why |
the history of workflow runs by this PR: https://github.com/lima-vm/lima/actions?query=branch%3Atest-port-forwarding.pl-use-socat+workflow%3Atest |
I'm sorry, I missed this. I would be happy to switch to |
To check failed logs in the workflow on local terminal, we can use |
support `socat` as a listener and writer. ```console $ ./hack/test-port-forwarding.pl default [nc|socat] [nc|socat] ``` The `nc` command always sets `SO_REUSEPORT` on the listening TCP port. The `socat` command provides a `reuseport` option that enables `SO_REUSEPORT` on the listening TCP port. Ref: lima-vm#4160 (comment) Signed-off-by: Norio Nomura <[email protected]> hack/test-port-forwarding.pl: Add a connection timeout option and relax it from 1 second to 3 seconds. Signed-off-by: Norio Nomura <[email protected]>
… on macOS Signed-off-by: Norio Nomura <[email protected]>
…nose` Signed-off-by: Norio Nomura <[email protected]>
… with `nc` Signed-off-by: Norio Nomura <[email protected]>
a8100de
to
067468e
Compare
I checked the |
I often see this failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Thanks! 🙏🏻 |
support
socat
as a listener and writer.$ ./hack/test-port-forwarding.pl default [nc|socat [nc|socat]] [timeout]
The
nc
command always setsSO_REUSEPORT
on the listening TCP port.The
socat
command provides areuseport
option that enablesSO_REUSEPORT
on the listening TCP port.Ref: #4160 (comment)
In the current code,Dropped an execution usingtest-port-forwarding.pl
is executed twice in each job usingnc
andsocat
for comparison.nc
.