doc: specific versions for consistency #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chickenandpork
force-pushed
the
doc/specific-versions-for-consistency
branch
from
38afecd to
b5a3b67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In deploying this project, I found that no container versions were given; that means docker will use "latest" as a version, which means that results can vary from day to day if any containers have been updated in that time.
I'd strongly suggest using specific versions, then allowing updates to be tested as functional before committing that new version to the main branch. This ensures the main branch works as a more important criterion than whether yesterday's update is automatically used and deployed without testing.
In this PR, I've used the versions or hashes that were pulled for me as "latest". They won't match "latest" when this PR is reviewed, but they'd still work the same as mine did.
As the same time -- perhaps because a newer version has different surprise behaviour -- I found that the icingaweb container needs to write logs, and lacks permission. I mitigated by mounting a volume on the log directory. Maybe not the best solution, but makes the main branch work today.