Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions llvm/include/llvm/BinaryFormat/Dwarf.h
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,15 @@ toDW_LNAME(SourceLanguage language) {
return {};
}

/// Returns a version-independent language name.
LLVM_ABI llvm::StringRef LanguageDescription(SourceLanguageName name);

/// Returns a language name corresponding to the specified version.
/// If the version is not recognized for the specified language, returns
/// the version-independent name.
LLVM_ABI llvm::StringRef LanguageDescription(SourceLanguageName Name,
uint32_t Version);

inline bool isCPlusPlus(SourceLanguage S) {
bool result = false;
// Deliberately enumerate all the language options so we get a warning when
Expand Down
111 changes: 111 additions & 0 deletions llvm/lib/BinaryFormat/Dwarf.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,117 @@ StringRef llvm::dwarf::LanguageDescription(dwarf::SourceLanguageName lname) {
return "Unknown";
}

StringRef llvm::dwarf::LanguageDescription(dwarf::SourceLanguageName Name,
uint32_t Version) {
switch (Name) {
// YYYY
case DW_LNAME_Ada: {
if (Version <= 1983)
return "Ada 83";
if (Version <= 1995)
return "Ada 95";
if (Version <= 2005)
return "Ada 2005";
if (Version <= 2012)
return "Ada 2012";
Comment on lines +480 to +487
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have expected these to work the other way around - like if the Version is < 1995, then it's Ada 83.

Might be weird to say it's Ada95 when the version is 1990/before 1995? But I'm not sure if there's a clear general sense, or language-specific sense, of what the intermediate values should mean.

Copy link
Member Author

@Michael137 Michael137 Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea those intermediate values haven't really been specified i think. I took inspiration from the logic in:

/// Convert a DWARF 6 pair of language name and version to a DWARF 5 DW_LANG.
/// If the version number doesn't exactly match a known version it is
/// rounded up to the next-highest known version number.
inline std::optional<SourceLanguage> toDW_LANG(SourceLanguageName name,
uint32_t version) {
switch (name) {
case DW_LNAME_Ada: // YYYY
if (version <= 1983)
return DW_LANG_Ada83;
if (version <= 1995)
return DW_LANG_Ada95;
if (version <= 2005)
return DW_LANG_Ada2005;
if (version <= 2012)
return DW_LANG_Ada2012;
return {};
case DW_LNAME_BLISS:
return DW_LANG_BLISS;
case DW_LNAME_C: // YYYYMM, K&R 000000
if (version == 0)
return DW_LANG_C;
if (version <= 198912)
return DW_LANG_C89;
if (version <= 199901)
return DW_LANG_C99;
if (version <= 201112)
return DW_LANG_C11;
if (version <= 201710)
return DW_LANG_C17;
return {};
case DW_LNAME_C_plus_plus: // YYYYMM
if (version == 0)
return DW_LANG_C_plus_plus;
if (version <= 199711)
return DW_LANG_C_plus_plus;
if (version <= 200310)
return DW_LANG_C_plus_plus_03;
if (version <= 201103)
return DW_LANG_C_plus_plus_11;
if (version <= 201402)
return DW_LANG_C_plus_plus_14;
if (version <= 201703)
return DW_LANG_C_plus_plus_17;
if (version <= 202002)
return DW_LANG_C_plus_plus_20;
return {};

There we round up the intermediate version number. Reading https://dwarfstd.org/languages-v6.html, it sounds like the version number specifies the completion of a particular language version. Anything after that is the next version. At least that's how I think about this

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a reasonable way to deal with pre-release compilers that guess the final date of the standard incorrectly. The other alternative would be put the raw version in the string.

} break;

case DW_LNAME_Cobol: {
if (Version <= 1974)
return "COBOL-74";
if (Version <= 1985)
return "COBOL-85";
} break;

case DW_LNAME_Fortran: {
if (Version <= 1977)
return "FORTRAN 77";
if (Version <= 1990)
return "FORTRAN 90";
if (Version <= 1995)
return "Fortran 95";
if (Version <= 2003)
return "Fortran 2003";
if (Version <= 2008)
return "Fortran 2008";
if (Version <= 2018)
return "Fortran 2018";
} break;

// YYYYMM
case DW_LNAME_C: {
if (Version == 0)
break;
if (Version <= 198912)
return "C89";
if (Version <= 199901)
return "C99";
if (Version <= 201112)
return "C11";
if (Version <= 201710)
return "C17";
} break;

case DW_LNAME_C_plus_plus: {
if (Version == 0)
break;
if (Version <= 199711)
return "C++98";
if (Version <= 200310)
return "C++03";
if (Version <= 201103)
return "C++11";
if (Version <= 201402)
return "C++14";
if (Version <= 201703)
return "C++17";
if (Version <= 202002)
return "C++20";
} break;

case DW_LNAME_ObjC_plus_plus:
case DW_LNAME_ObjC:
case DW_LNAME_Move:
case DW_LNAME_SYCL:
case DW_LNAME_BLISS:
case DW_LNAME_Crystal:
case DW_LNAME_D:
case DW_LNAME_Dylan:
case DW_LNAME_Go:
case DW_LNAME_Haskell:
case DW_LNAME_HLSL:
case DW_LNAME_Java:
case DW_LNAME_Julia:
case DW_LNAME_Kotlin:
case DW_LNAME_Modula2:
case DW_LNAME_Modula3:
case DW_LNAME_OCaml:
case DW_LNAME_OpenCL_C:
case DW_LNAME_Pascal:
case DW_LNAME_PLI:
case DW_LNAME_Python:
case DW_LNAME_RenderScript:
case DW_LNAME_Rust:
case DW_LNAME_Swift:
case DW_LNAME_UPC:
case DW_LNAME_Zig:
case DW_LNAME_Assembly:
case DW_LNAME_C_sharp:
case DW_LNAME_Mojo:
case DW_LNAME_GLSL:
case DW_LNAME_GLSL_ES:
case DW_LNAME_OpenCL_CPP:
case DW_LNAME_CPP_for_OpenCL:
case DW_LNAME_Ruby:
case DW_LNAME_Hylo:
case DW_LNAME_Metal:
break;
}

// Fallback to un-versioned name.
return LanguageDescription(Name);
}

StringRef llvm::dwarf::CaseString(unsigned Case) {
switch (Case) {
case DW_ID_case_sensitive:
Expand Down
38 changes: 38 additions & 0 deletions llvm/unittests/BinaryFormat/DwarfTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -219,4 +219,42 @@ TEST(DwarfTest, lname) {
EXPECT_EQ(roundtrip(DW_LANG_##NAME), DW_LANG_##NAME);
#include "llvm/BinaryFormat/Dwarf.def"
}

TEST(DWARFDebugInfo, TestLanguageDescription_Versioned) {
// Tests for the llvm::dwarf::LanguageDescription API that
// takes a name *and* a version.

// Unknown language.
EXPECT_EQ(
llvm::dwarf::LanguageDescription(static_cast<SourceLanguageName>(0)),
"Unknown");

EXPECT_EQ(
llvm::dwarf::LanguageDescription(static_cast<SourceLanguageName>(0), 0),
"Unknown");

// Test that specifying an invalid version falls back to a valid language name
// regardless.
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_ObjC, 0), "Objective C");
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_Julia, 0), "Julia");

// Check some versions.
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 199711),
"C++98");
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 201402),
"C++14");

// Versions round up.
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 201400),
"C++14");

// Version 0 for C and C++ is an unversioned name.
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C, 0), "C (K&R and ISO)");
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_C_plus_plus, 0),
"ISO C++");

// Version 0 for other versioned languages may not be the unversioned name.
EXPECT_EQ(llvm::dwarf::LanguageDescription(DW_LNAME_Fortran, 0),
"FORTRAN 77");
}
} // end namespace
1 change: 0 additions & 1 deletion llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2275,5 +2275,4 @@ TEST(DWARFDebugInfo, TestDWARF64UnitLength) {
ASSERT_EQ(0x1122334455667788ULL, CU.getLength());
});
}

} // end anonymous namespace