Skip to content

[lldb][Language] Make SourceLanguage::GetDescription for language version #162050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[lldb][Language] Make SourceLanguage::GetDescription for language version #162050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7181bd
[llvm][Dwarf] Add LanguageDescription API that accounts for version
Michael137 Oct 6, 2025
2770852
[lldb][Language] Make SourceLanguage::GetDescription for language ver…
Michael137 Oct 6, 2025
054d91d
fixup! clang-format
Michael137 Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Target/Language.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,7 @@ lldb::LanguageType SourceLanguage::AsLanguageType() const {

llvm::StringRef SourceLanguage::GetDescription() const {
return llvm::dwarf::LanguageDescription(
static_cast<llvm::dwarf::SourceLanguageName>(name));
static_cast<llvm::dwarf::SourceLanguageName>(name), version);
}
bool SourceLanguage::IsC() const { return name == llvm::dwarf::DW_LNAME_C; }

Expand Down
7 changes: 5 additions & 2 deletions lldb/unittests/Target/LanguageTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,12 @@ TEST_F(LanguageTest, SourceLanguage_GetDescription) {
EXPECT_EQ(SourceLanguage(eLanguageTypeC_plus_plus).GetDescription(),
"ISO C++");
EXPECT_EQ(SourceLanguage(eLanguageTypeC_plus_plus_17).GetDescription(),
"ISO C++");
"C++17");
EXPECT_EQ(SourceLanguage(eLanguageTypeC_plus_plus_20).GetDescription(),
"ISO C++");
"C++20");

EXPECT_EQ(SourceLanguage(eLanguageTypeC).GetDescription(), "C (K&R and ISO)");
EXPECT_EQ(SourceLanguage(eLanguageTypeC89).GetDescription(), "C89");

EXPECT_EQ(SourceLanguage(eLanguageTypeObjC).GetDescription(), "Objective C");
EXPECT_EQ(SourceLanguage(eLanguageTypeMipsAssembler).GetDescription(),
Expand Down
7 changes: 7 additions & 0 deletions llvm/include/llvm/BinaryFormat/Dwarf.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,8 +500,15 @@ toDW_LNAME(SourceLanguage language) {
return {};
}

/// Returns a version-independent language name.
LLVM_ABI llvm::StringRef LanguageDescription(SourceLanguageName name);

/// Returns a language name corresponding to the specified version.
/// If the version is not recognized for the specified language, returns
/// the version-independent name.
LLVM_ABI llvm::StringRef LanguageDescription(SourceLanguageName Name,
uint32_t Version);

inline bool isCPlusPlus(SourceLanguage S) {
bool result = false;
// Deliberately enumerate all the language options so we get a warning when
Expand Down
111 changes: 111 additions & 0 deletions llvm/lib/BinaryFormat/Dwarf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -472,6 +472,117 @@ StringRef llvm::dwarf::LanguageDescription(dwarf::SourceLanguageName lname) {
return "Unknown";
}

StringRef llvm::dwarf::LanguageDescription(dwarf::SourceLanguageName Name,
uint32_t Version) {
switch (Name) {
// YYYY
case DW_LNAME_Ada: {
if (Version <= 1983)
return "Ada 83";
if (Version <= 1995)
return "Ada 95";
if (Version <= 2005)
return "Ada 2005";
if (Version <= 2012)
return "Ada 2012";
} break;

case DW_LNAME_Cobol: {
if (Version <= 1974)
return "COBOL-74";
if (Version <= 1985)
return "COBOL-85";
} break;

case DW_LNAME_Fortran: {
if (Version <= 1977)
return "FORTRAN 77";
if (Version <= 1990)
return "FORTRAN 90";
if (Version <= 1995)
return "Fortran 95";
if (Version <= 2003)
return "Fortran 2003";
if (Version <= 2008)
return "Fortran 2008";
if (Version <= 2018)
return "Fortran 2018";
} break;

// YYYYMM
case DW_LNAME_C: {
if (Version == 0)
break;
if (Version <= 198912)
return "C89";
if (Version <= 199901)
return "C99";
if (Version <= 201112)
return "C11";
if (Version <= 201710)
return "C17";
} break;

case DW_LNAME_C_plus_plus: {
if (Version == 0)
break;
if (Version <= 199711)
return "C++98";
if (Version <= 200310)
return "C++03";
if (Version <= 201103)
return "C++11";
if (Version <= 201402)
return "C++14";
if (Version <= 201703)
return "C++17";
if (Version <= 202002)
return "C++20";
} break;

case DW_LNAME_ObjC_plus_plus:
case DW_LNAME_ObjC:
case DW_LNAME_Move:
case DW_LNAME_SYCL:
case DW_LNAME_BLISS:
case DW_LNAME_Crystal:
case DW_LNAME_D:
case DW_LNAME_Dylan:
case DW_LNAME_Go:
case DW_LNAME_Haskell:
case DW_LNAME_HLSL:
case DW_LNAME_Java:
case DW_LNAME_Julia:
case DW_LNAME_Kotlin:
case DW_LNAME_Modula2:
case DW_LNAME_Modula3:
case DW_LNAME_OCaml:
case DW_LNAME_OpenCL_C:
case DW_LNAME_Pascal:
case DW_LNAME_PLI:
case DW_LNAME_Python:
case DW_LNAME_RenderScript:
case DW_LNAME_Rust:
case DW_LNAME_Swift:
case DW_LNAME_UPC:
case DW_LNAME_Zig:
case DW_LNAME_Assembly:
case DW_LNAME_C_sharp:
case DW_LNAME_Mojo:
case DW_LNAME_GLSL:
case DW_LNAME_GLSL_ES:
case DW_LNAME_OpenCL_CPP:
case DW_LNAME_CPP_for_OpenCL:
case DW_LNAME_Ruby:
case DW_LNAME_Hylo:
case DW_LNAME_Metal:
break;
}

// Fallback to un-versioned name.
return LanguageDescription(Name);
}

StringRef llvm::dwarf::CaseString(unsigned Case) {
switch (Case) {
case DW_ID_case_sensitive:
Expand Down