Skip to content

Conversation

mingzheTerapines
Copy link

Co-authored by: [email protected]

Fix bug for AtenOnes/AtenZeros/AtenFullOp fold function.
Specify using mlir namespace for Integer/FloatType which was unexpected used in torch namespace.

Co-authored by: [email protected]

Fix bug for AtenOnes/AtenZeros/AtenFullOp fold function.
Specify using mlir namespace for Integer/FloatType which was unexpected used in torch namespace.
Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch!

It looks like you need to run pre-commit or clang-format, but otherwise LGTM.

If you get the chance to add a standalone unit test for these changes, that would also be appreciated.

@mingzheTerapines
Copy link
Author

mingzheTerapines commented Sep 26, 2025

Ah, nice catch!

It looks like you need to run pre-commit or clang-format, but otherwise LGTM.

If you get the chance to add a standalone unit test for these changes, that would also be appreciated.

Thx for aprroving. Pre-commit is now working. Also unit-tests were added.

Copy link
Collaborator

@zjgarvey zjgarvey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Let me know if you want me to squash and merge.

@mingzheTerapines
Copy link
Author

Nice. Let me know if you want me to squash and merge.

Please help me squash and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants