Skip to content

Conversation

karenzone
Copy link
Contributor

Improve documentation by adding meaningful examples

@karenzone karenzone added the docs label Aug 11, 2021
@karenzone
Copy link
Contributor Author

Replaces #146

Copy link
Contributor

@kares kares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these examples won't behave as expected with hosts => "${ES_HOSTS}"


* `ES_HOSTS="es1.example.com es2.example.com:9201 es3.example.com:9201"`
* `ES_HOSTS="127.0.0.1:9200 127.0.0.2:9200"`
* `ES_HOSTS="http://127.0.0.1 http://127.0.0.2"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what the back-story is but these aren't working properly.
the first 2 examples will start although I do not think the host fall-over is working (only the first entry is extracted by the client library). for the second half of examples - they simply fail to start the plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants