Skip to content

Conversation

lrstanley
Copy link
Owner

@lrstanley lrstanley commented Apr 29, 2025

Warning

THIS SHOULD NOT BE MERGED UNTIL the Charm team has fully released all of the associated charm libraries.
This PR is currently tagged as github.com/lrstanley/bubblezone/v2 @ v2.0.0-alpha.2. Use with:

go get github.com/lrstanley/bubblezone/[email protected]

You can find the API for v2 here: https://pkg.go.dev/github.com/lrstanley/bubblezone/[email protected]


🚀 Changes proposed by this PR

  • Switch the following deps to v2 variants (breaking change):
    • github.com/charmbracelet/bubbletea/v2
    • github.com/charmbracelet/lipgloss/v2
    • github.com/charmbracelet/bubbles/v2

TODO

  • Move away from the lipgloss compat for v2, and switch examples away from adaptive.
  • Investigate better alternatives to all of the type casting WRT tea.Model and tea.ViewModel -- everything I have now is just temporary for now I think.
  • See if we can replace the usage of github.com/muesli/ansi
  • Update examples to use v2 of this library.
  • Update readme to use v2 of this library.

🔗 Related bug reports/feature requests

🧰 Type of change

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that causes existing functionality to not work as expected).
  • This change requires (or is) a documentation update.

🤝 Requirements

  • ✍ I have read and agree to this projects Code of Conduct.
  • ✍ I have read and agree to this projects Contribution Guidelines.
  • ✍ I have read and agree to the Developer Certificate of Origin.
  • 🔎 I have performed a self-review of my own changes.
  • 🎨 My changes follow the style guidelines of this project.
  • 💬 My changes as properly commented, primarily for hard-to-understand areas.
  • 📝 I have made corresponding changes to the documentation.
  • 🧪 I have included tests (if necessary) for this change.

@lrstanley lrstanley self-assigned this Apr 29, 2025
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (0250061) to head (27a4c72).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   94.07%   94.48%   +0.40%     
==========================================
  Files           5        5              
  Lines         270      290      +20     
==========================================
+ Hits          254      274      +20     
  Misses         15       15              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Liam Stanley <[email protected]>
Signed-off-by: Liam Stanley <[email protected]>
@aymanbagabas
Copy link

Hey @lrstanley, just want to drop this in and let you know that we're using this branch and patches in Soft Serve v2 https://github.com/aymanbagabas/bubblezone/tree/v2-exp. Please let me know if you have any comments or concerns 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Support V2 BETA
2 participants