Skip to content

DM-53046: Experiments with speeding up the ANTL4-based query parser of Qserv #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

DM-53046: Experiments with speeding up the ANTL4-based query parser of Qserv #973

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f9342aa
TEMPORARY: unlock the query parsing stage
iagaponenko Sep 5, 2025
0a181a5
TEMPORARY: compiling parser with the one-thread-per-parser option
iagaponenko Sep 10, 2025
79911a0
TEMPORARY: eliminated any logging on the critical path of the parser
iagaponenko Sep 5, 2025
69b0ba9
TEMPORARY: simplified ANTLR4 grammar description.
iagaponenko Sep 11, 2025
4e225a8
TEMPORARY: custom version of ANTLR4
iagaponenko Sep 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/docker/base/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,9 @@ RUN cd /tmp \
RUN cd /usr/share/java \
&& curl -O https://www.antlr.org/download/antlr-4.13.2-complete.jar \
&& cd /tmp \
&& git clone https://github.com/antlr/antlr4 \
&& git clone https://github.com/iagaponenko/antlr4.git \
&& cd antlr4 \
&& git checkout 4.13.2 \
&& git checkout qserv \
&& git config user.email "qserv@qserv-build" \
&& mkdir runtime/Cpp/build \
&& cd runtime/Cpp/build \
Expand Down
4 changes: 2 additions & 2 deletions src/ccontrol/ParseAdapters.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ class Adapter {
// passed in to CALLBACK_INFO
template <typename CALLBACK_INFO>
void trace_callback_info(std::string const& function, CALLBACK_INFO const& callbackInfo) {
LOGS(_log, LOG_LVL_TRACE, name() << function << " " << callbackInfo);
// LOGS(_log, LOG_LVL_TRACE, name() << function << " " << callbackInfo);
}

static LOG_LOGGER _log;
Expand Down Expand Up @@ -1706,7 +1706,7 @@ class SimpleIdAdapter : public AdapterT<SimpleIdCBH, QSMySqlParser::SimpleIdCont
} else if (_ctx->functionNameBase() != nullptr) {
return;
} else if (_ctx->keywordsCanBeId() != nullptr) {
LOGS(_log, LOG_LVL_WARN, __FUNCTION__ << " reusing keyword as ID: " << _ctx->getText());
// LOGS(_log, LOG_LVL_WARN, __FUNCTION__ << " reusing keyword as ID: " << _ctx->getText());
return;
}
assertNotSupported(__FUNCTION__, false, "Unsupported SimpleId", _ctx);
Expand Down
Loading