Skip to content

LL 346: Create test directory #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 26, 2025
Merged

LL 346: Create test directory #10

merged 8 commits into from
Sep 26, 2025

Conversation

@greypilgrim
Copy link
Contributor

@greypilgrim greypilgrim commented Sep 3, 2025 •
edited
Loading

PR Description

Configure coverage with jest

What type of PR is this? (check all applicable)

  • 🔧 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🔨 Build
  • 🔁 CI

Why is this PR important?

To adequately test code, search for dead code, etc.

Related Tickets & Documents

@Verus20 LL-351

How to test

  1. Open terminal in repo
  2. run npm i
  3. run npx jest
  4. Confirm report was generated
  5. profit

Added to documentation?

  • 📜 README.md
  • 📓 Github pages
  • 📕 Confluence
  • 🆕 Other (if so please list here)
  • ❌ no documentation needed

[optional] What gif best describes this PR?

https://media.giphy.com/media/v1.Y2lkPTc5MGI3NjExNGlkcjMyMnplZng3NmV6d243bDAwM3ZoaHp5b3dneGQ3eW1pY2F3OCZlcD12MV9naWZzX3NlYXJjaCZjdD1n/6d1Q6XoDH4Kl7pc36D/giphy.gif

@greypilgrim greypilgrim marked this pull request as ready for review September 3, 2025 04:35
@greypilgrim greypilgrim requested a review from pogi7 September 3, 2025 04:36
@pogi7 pogi7 requested a review from Verus20 September 3, 2025 05:13
pogi7
pogi7 reviewed Sep 3, 2025
View reviewed changes
pogi7
pogi7 requested changes Sep 3, 2025
View reviewed changes
Copy link
Contributor

@pogi7 pogi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to defer to @Verus20 for merging this code, since it's related to his ticket.
Please title PRs with the ticket name somewhere in the PR title. So LL-346 would be a good PR title name.

Verus20
Verus20 requested changes Sep 4, 2025
View reviewed changes
Copy link

@Verus20 Verus20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding in some documentation to the README to explain how to run code coverage, i.e if you were showing someone new to LL how to run code coverage how would they go about doing that?

other then that doc update, lgtm

@greypilgrim greypilgrim changed the title Create test directory LL 346: Create test directory Sep 12, 2025
@greypilgrim
Delete unused hello.test.ts placeholder file. Update README.md to inc…
0fc6de3 
…lude instructions on running coverage testing

Signed-off-by: greypilgrim <[email protected]>
@greypilgrim
Copy link
Contributor Author

greypilgrim commented Sep 12, 2025

@pogi7 @Verus20 Made the changes and pushed, just need review(if necessary) and okay to merge

pogi7
pogi7 approved these changes Sep 13, 2025
View reviewed changes
Copy link
Contributor

@pogi7 pogi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Verus20
Verus20 approved these changes Sep 14, 2025
View reviewed changes
Copy link

@Verus20 Verus20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pogi7
Merge pull request #11 from luminosityleds/LL-351
bcb1f52 
LL-351: Setup testing framework for browser repo
@codecov
Copy link

codecov bot commented Sep 26, 2025

⚠️ JUnit XML file not found

The CLI was unable to find any JUnit XML files to upload.
For more help, visit our troubleshooting guide.

@pogi7
Copy link
Contributor

pogi7 commented Sep 26, 2025

CI/CD fails since no passes are defined yet. Will add tests in other PRs.

@pogi7 pogi7 merged commit 7b1eabf into master Sep 26, 2025
1 check failed
@pogi7 pogi7 deleted the LL-346-Setup-code-coverage-for-browser-repo branch September 26, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Verus20 Verus20 Verus20 approved these changes

@pogi7 pogi7 pogi7 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@greypilgrim @pogi7 @Verus20