Skip to content

ci: add addlicense linter to CI workflow for license checks #2625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

ci: add addlicense linter to CI workflow for license checks #2625

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
31b548b
ci: add addlicense linter to CI workflow for license checks
Aswinr24 Mar 12, 2025
575255f
fix: replace curl & grep with gh cli to download package, improved er…
Aswinr24 Mar 14, 2025
f346022
ci: add sudo to fix apt permission issues in GitHub Actions
Aswinr24 Mar 14, 2025
89fe367
fix: Add GH_TOKEN for GitHub CLI authentication
Aswinr24 Mar 14, 2025
bca336b
fix: update rls version
Aswinr24 Mar 14, 2025
199a169
fix: ignore protocol buffer files
Aswinr24 Mar 14, 2025
9c6b1ae
fix: ignore workflow files
Aswinr24 Mar 14, 2025
4475555
fix: license check workflow to properly detect and report missing hea…
Aswinr24 Mar 14, 2025
5d32446
Merge branch 'master' into master
Aswinr24 Mar 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,31 @@ jobs:
run: pre-commit run flake8 --hook-stage manual
- name: Check types with mypy
run: pre-commit run mypy --hook-stage manual
- name: Install GitHub CLI
run: |
sudo apt update
sudo apt install gh -y
- name: Check imports against dependencies
run: pre-commit run deptry --hook-stage manual
env:
GH_TOKEN: ${{ github.token }}
run: |
gh release download v1.1.1 --repo google/addlicense --pattern "addlicense_*_Linux_x86_64.tar.gz"
tar -xzf addlicense_*_Linux_x86_64.tar.gz
chmod +x addlicense
sudo mv addlicense /usr/local/bin/
rm addlicense_*_Linux_x86_64.tar.gz
- name: Check license headers
run: |
addlicense -check \
-c "Google LLC" \
-ignore "**/*_pb2.py" \
-ignore "**/*_pb2.pyi" \
-ignore "**/__init__.py" \
-ignore "**/.*" \
-ignore "**/.*/**" . || {
echo "License headers missing or incorrect! Please run 'addlicense -c \"Google LLC\" .' locally and commit the changes."
exit 1
}

rule_linter:
runs-on: ubuntu-22.04
Expand Down