Add runge-kutta R6RS example as benchmark #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the fib benchmark and degrades the integration benchmark. Importantly, however, it prevents runaway memory usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This example works, but is quite slow, so this PR adds it as a benchmark.
This PR also adds a maximum number of pending mutations to the garbage collector, effectively halting runaway memory growth that sometimes occurs with recursive functions. This can probably be tweaked, and shows about a 8% perf regression in the fib benchmark. That's really not a lot, especially considering we'll probably have some more big optimizations in the future that completely erase that regression.
What can improve this benchmark? I think that mostly this is due to having a few functions defined in scheme rather than as Rust builtins. Functions like
mapshould probably be moved to Rust. After that, some analysis of the CPS IR is probably necessary. Maybe I can finally add eta reduction.