Improve and fix spline #610
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FilippoOlivo
added
bug
FilippoOlivo
added
pr-to-review
FilippoOlivo
requested review from
GiovanniCanali,
dario-coscia and
ndem0
and removed request for
GiovanniCanali
GiovanniCanali
requested changes
Aug 5, 2025
There was a problem hiding this comment.
Hi @FilippoOlivo,
I left some comments to be addressed before the approval.
Please, add some comments in the for loop of the basis function to explain better what is being computed. Also, I would remove the comments on shapes all over the code.
At last, I would update the tests since we changed a bit the logic.
|
Any update on this PR? |
GiovanniCanali
added
pr-to-fix
GiovanniCanali
force-pushed
the
spline
branch
3 times, most recently
from
9762ad2 to
ac37e9b
Compare
Co-authored-by: Filippo Olivo <[email protected]> Co-authored-by: ajacoby9 <[email protected]>
GiovanniCanali
force-pushed
the
spline
branch
2 times, most recently
from
3094aa4 to
8b0fc2b
Compare
GiovanniCanali
added
pr-to-review
GiovanniCanali
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #609.
Checklist