zksync factory #170
Open
zksync factory #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Wolf <[email protected]>
wolfy-nft
commented
Jan 23, 2025
| } | ||
|
|
||
| // Create a deterministic clone of the implementation contract | ||
| address instance = address(new ZKProxy{salt: salt}(impl)); |
Contributor
Author
There was a problem hiding this comment.
replaced LibClone
wolfy-nft
commented
Jan 23, 2025
| } | ||
|
|
||
| // Create a non-deterministic clone of the implementation contract | ||
| address instance = address(new ZKProxy(impl)); |
Contributor
Author
There was a problem hiding this comment.
replaced LibClone
XTHuo-Magic
reviewed
Jan 24, 2025
| import {LibClone} from "solady/src/utils/LibClone.sol"; | ||
|
|
||
| import {MagicDropCloneFactory} from "../../contracts/factory/MagicDropCloneFactory.sol"; | ||
| import {MagicDropCloneFactory} from "../../contracts/factory/zksync/MagicDropCloneFactory.sol"; |
There was a problem hiding this comment.
Should we create a new test file for the zksync factory?
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Signed-off-by: Adam Wolf <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced LibClone with ZKProxy
factory
registry; no changes required, but showign tests pass with zksync flag
