fix: Intermittent test failure in cicd from newing in unit test
#233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update avalanche factory and registry address - update chain implementation Ids
tenthirtyone
changed the title
newing in unit test
rovilay
approved these changes
Jul 17, 2025
rovilay
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent test failure experienced by #232 #231
It think this may have been introduced in #172. In my fork, this is the earliest failure I see in the commit history, but it differs on every fork I checked.
For whatever reason, occasionally this test will encounter an issue where
new'ing a contract deployment collides with an existing contract deployment. This is probably a race condition in the nonce mgmt or test network setup/teardown given the error message:CreateCollisionindicates contract code exists at the desired address. At first, this seemed like it was an issue in the deterministic deployment. I rotated the salt values of each one without any change.Refactoring the InvalidImplementation to deploy during test setup fixed the issue.