EHN: normalize paths coming from meson introspection data #785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Meson 1.9.0 changes some paths stored in introspection data use POSIX-style path separators on Windows too. This adds path normalization where it matters. Fixes mesonbuild#778.
dnicolodi
force-pushed
the
win-paths-normalization
branch
from
63e7c61 to
775b3c8
Compare
|
@rgommers Do you have time to have a look at this? |
rgommers
added
the
maintenance
|
Marked this for 0.19.0, I assume we'll do that soon rather than 0.18.1 |
|
The commit that made this necessary has been reverted in Meson mesonbuild/meson#14922 I'd keep the normalization anyway as it does not do any harm. |
|
Ah good to know.
👍🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meson 1.9.0 changes some paths stored in introspection data use POSIX-style path separators on Windows too. This adds path normalization where it matters.
Fixes #778.