Add instructions for cibuildwheel to support Windows wheels #794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I had trouble with building wheels ("Python executable could not be found") and fixed it by specifying the `vsenv` option for cibuildwheel. A similar flag is used by numpy as well, so this is probably indeed needed.
moi15moi
reviewed
Sep 21, 2025
Comment on lines
+193
to
+195
| # In case you want to build Windows wheels using cibuildwheel | ||
| [tool.cibuildwheel.windows] | ||
| config-settings = { setup-args = ["--vsenv"] } |
There was a problem hiding this comment.
I think this won't properly work when you are building the wheel on cygwin/msys2
There was a problem hiding this comment.
That is true. But since the whole section was about MSVC, I saw little risk of someone adding this option while actually building the wheel on msys2. Do you think this needs further clarification, eg in the comment above the snippet?
There was a problem hiding this comment.
Oh my bad, i didnt realized that it was part of a MSVC section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble with building wheels ("Python executable could not be found") and fixed it by specifying the
vsenvoption for cibuildwheel. A similar flag is used by numpy as well, so this is probably indeed needed.