Skip to content

Conversation

crvux
Copy link
Contributor

@crvux crvux commented Jul 10, 2025

No description provided.

@crvux crvux force-pushed the eyalroz-printf branch 2 times, most recently from 2010f8a to 48303da Compare July 10, 2025 16:42
@crvux
Copy link
Contributor Author

crvux commented Jul 10, 2025

lead_directory_missing = true it is because zipped dir name is printf-<some_version> which can very easily lead to a collision. So we use the directory is named the same as this package as "safety" layer

@crvux crvux marked this pull request as ready for review July 10, 2025 16:51
@crvux crvux requested a review from bgilbert July 15, 2025 11:32
@crvux
Copy link
Contributor Author

crvux commented Jul 29, 2025

@bgilbert are there any other shortcomings that need to be fixed?

@crvux
Copy link
Contributor Author

crvux commented Aug 28, 2025

@bgilbert friendly ping

Signed-off-by: Alexander Voronov <[email protected]>
@crvux
Copy link
Contributor Author

crvux commented Aug 29, 2025

@eli-schwartz I tried to port the logic with a minimum number of changes, that's why there are so many compiler flags in the tests
https://github.com/eyalroz/printf/blob/master/test/CMakeLists.txt#L54
For now I still left some of the compiler warnings. Do you think it's worth removing?

I also had to comment out the build of one test (printf.test_suite), because ci run tests and one check is failed (in original cmake build is too). I hope this will be fixed in the next library release.

@crvux crvux requested a review from eli-schwartz August 29, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants