-
Notifications
You must be signed in to change notification settings - Fork 255
s2n-tls: add wrap for v1.5.24 #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
S2N doesn't support windows, and the alpine sanity check is failing because the openssl wrap also doesn't work on alpine |
Install the openssl development headers in the CI config for this wrap, then! |
Annoying that the msys2 and windows builds still show as failed despite disabling them in |
Correct. You're supposed to add an unsupported message for windows. |
should be optional, no? |
Definitely if you intend to support Windows, yes. math.h exists but the library provider is built-in rather than being an external libm.a or libm.so There are some Unix systems where it's built-in as well, but those generally provide a stub libm.a to satisfy the posix requirement that "the |
Third times the charm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not required, but if upstream has some basic self-tests that could be added as Meson tests, that'd be good. (Especially for a crypto library.)
# echo " '$f'," | ||
# done | ||
examples_src = [ | ||
'docs/examples/s2n_negotiate.c', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's potentially clearer to move build directives for subdirectories into subdirectory meson.build
files, but that isn't required.
@eli-schwartz Any blockers for merging this changeset? |
Haven't looked closely (yet) but that is a suspiciously large number of commits, some of which definitely roll back changes made earlier in this patch series. Please squash commits. |
0f24c03
to
86f3a91
Compare
Adds a wrap for Amazon S2N version 1.5.24