-
Notifications
You must be signed in to change notification settings - Fork 99
Enable worker logs on IPython #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pablorfb-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83712603. |
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Oct 2, 2025
Summary: Logs do not show on Notebooks running monarch with no Conda Why are FD watchers needed on IPython (Bento/Colab)? - On notebook, the top level process is IPython kernel which captures Python streams (sys.stdout/sys.stderr) - Monarch routes logs to parent’s process io::stdout/stderr (OS File Descriptors 1 and 2), which the IPython Kernel does not monitor by default - On buck, the top process is the Monarch binary itself, meaning that FD 1/2 are connected to the terminal, so logs show up automatically - monarch_conda automatically displays all logs More context: https://fburl.com/gdoc/36pyayi5 Differential Revision: D83712603
18a9d03 to
7138949
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Oct 3, 2025
Summary: Logs do not show on Notebooks running monarch with no Conda Why are FD watchers needed on IPython (Bento/Colab)? - On notebook, the top level process is IPython kernel which captures Python streams (sys.stdout/sys.stderr) - Monarch routes logs to parent’s process io::stdout/stderr (OS File Descriptors 1 and 2), which the IPython Kernel does not monitor by default - On buck, the top process is the Monarch binary itself, meaning that FD 1/2 are connected to the terminal, so logs show up automatically - monarch_conda automatically displays all logs More context: https://fburl.com/gdoc/36pyayi5 Reviewed By: pzhan9 Differential Revision: D83712603
7138949 to
88371f2
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Oct 6, 2025
Summary: Logs do not show on Notebooks running monarch with no Conda Why are FD watchers needed on IPython (Bento/Colab)? - On notebook, the top level process is IPython kernel which captures Python streams (sys.stdout/sys.stderr) - Monarch routes logs to parent’s process io::stdout/stderr (OS File Descriptors 1 and 2), which the IPython Kernel does not monitor by default - On buck, the top process is the Monarch binary itself, meaning that FD 1/2 are connected to the terminal, so logs show up automatically - monarch_conda automatically displays all logs More context: https://fburl.com/gdoc/36pyayi5 Reviewed By: pzhan9 Differential Revision: D83712603
88371f2 to
5c31824
Compare
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Oct 10, 2025
Summary: Logs do not show on Notebooks running monarch with no Conda Why are FD watchers needed on IPython (Bento/Colab)? - On notebook, the top level process is IPython kernel which captures Python streams (sys.stdout/sys.stderr) - Monarch routes logs to parent’s process io::stdout/stderr (OS File Descriptors 1 and 2), which the IPython Kernel does not monitor by default - On buck, the top process is the Monarch binary itself, meaning that FD 1/2 are connected to the terminal, so logs show up automatically - monarch_conda automatically displays all logs More context: https://fburl.com/gdoc/36pyayi5 Reviewed By: pzhan9 Differential Revision: D83712603
pablorfb-meta
added a commit
to pablorfb-meta/monarch
that referenced
this pull request
Oct 10, 2025
Summary: Logs do not show on Notebooks running monarch with no Conda Why are FD watchers needed on IPython (Bento/Colab)? - On notebook, the top level process is IPython kernel which captures Python streams (sys.stdout/sys.stderr) - Monarch routes logs to parent’s process io::stdout/stderr (OS File Descriptors 1 and 2), which the IPython Kernel does not monitor by default - On buck, the top process is the Monarch binary itself, meaning that FD 1/2 are connected to the terminal, so logs show up automatically - monarch_conda automatically displays all logs More context: https://fburl.com/gdoc/36pyayi5 Reviewed By: pzhan9 Differential Revision: D83712603
5c31824 to
287d8db
Compare
Summary: Logs do not show on Notebooks running monarch with no Conda Why are FD watchers needed on IPython (Bento/Colab)? - On notebook, the top level process is IPython kernel which captures Python streams (sys.stdout/sys.stderr) - Monarch routes logs to parent’s process io::stdout/stderr (OS File Descriptors 1 and 2), which the IPython Kernel does not monitor by default - On buck, the top process is the Monarch binary itself, meaning that FD 1/2 are connected to the terminal, so logs show up automatically - monarch_conda automatically displays all logs More context: https://fburl.com/gdoc/36pyayi5 Reviewed By: pzhan9 Differential Revision: D83712603
287d8db to
b973d76
Compare
|
This pull request has been merged in 22dc699. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
Summary: Pull Request resolved: meta-pytorch#1407 Logs do not show on Notebooks running monarch with no Conda Why are FD watchers needed on IPython (Bento/Colab)? - On notebook, the top level process is IPython kernel which captures Python streams (sys.stdout/sys.stderr) - Monarch routes logs to parent’s process io::stdout/stderr (OS File Descriptors 1 and 2), which the IPython Kernel does not monitor by default - On buck, the top process is the Monarch binary itself, meaning that FD 1/2 are connected to the terminal, so logs show up automatically - monarch_conda automatically displays all logs More context: https://fburl.com/gdoc/36pyayi5 Reviewed By: pzhan9 Differential Revision: D83712603 fbshipit-source-id: 3bf3ac1a1b65def7e1ff461f137385957e64a023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Logs do not show on Notebooks running monarch with no Conda
Why are FD watchers needed on IPython (Bento/Colab)?
More context: https://fburl.com/gdoc/36pyayi5
Differential Revision: D83712603