Turn on cargo test for the hyperactor crates #1417
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@dulinriley has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83856634. |
dulinriley
force-pushed
the
export-D83856634
branch
from
5f42bb7 to
3dcbf0d
Compare
Summary: Pull Request resolved: meta-pytorch#1417 We should have Rust tests run in Github CI to ensure we don't break them. Before we were blocked on issues with `cargo test` running tests in threads, and we need process isolation because our tests modify things like environment variables. Use `cargo nextest` which is a package that runs test in parallel processes instead of threads. For now, just run these in a GPU environment. A cpu-only run may be beneficial for either cost savings, faster iteration cycles, or for test coverage itself. But I'll add that later. Some tests are failing in Github but not internally. Add a feature to skip these called "fb". Reviewed By: mariusae Differential Revision: D83856634
dulinriley
force-pushed
the
export-D83856634
branch
from
3dcbf0d to
d84f9cf
Compare
|
This pull request has been merged in 6b6136c. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
We should have Rust tests run in Github CI to ensure we don't break them.
Before we were blocked on issues with
cargo testrunning tests in threads, and weneed process isolation because our tests modify things like environment variables.
Use
cargo nextestwhich is a package that runs test in parallel processes instead ofthreads.
Differential Revision: D83856634