add optional dependencies to setup.py; add examples for requirements.txt in examples #1430
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
@colin2328 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D83884709. |
colin2328
added a commit
to colin2328/monarch-1
that referenced
this pull request
Oct 3, 2025
…txt in examples (meta-pytorch#1430) Summary: we want to introduce (long term) optional deps for rdma, tensor_engine. short term, we should put deps on exmaples. This adds to setup.py Differential Revision: D83884709
colin2328
force-pushed
the
export-D83884709
branch
from
7feed8a to
50fdf64
Compare
…txt in examples (meta-pytorch#1430) Summary: we want to introduce (long term) optional deps for rdma, tensor_engine. short term, we should put deps on exmaples. This adds to setup.py Reviewed By: johnwhumphreys, dcci Differential Revision: D83884709
colin2328
force-pushed
the
export-D83884709
branch
from
50fdf64 to
8435531
Compare
|
This pull request has been merged in c702b0e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
we want to introduce (long term) optional deps for rdma, tensor_engine.
short term, we should put deps on exmaples.
This adds to setup.py
Differential Revision: D83884709