Skip to content

[monarch] Prevent PyGILState_Release fatal in test_mesh_len #1432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[monarch] Prevent PyGILState_Release fatal in test_mesh_len #1432

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
795161b
[monarch] Prevent PyGILState_Release fatal in test_mesh_len
samlurye Oct 4, 2025
c6dc991
Update on "[monarch] Prevent PyGILState_Release fatal in test_mesh_len"
samlurye Oct 4, 2025
e337c7e
Update on "[monarch] Prevent PyGILState_Release fatal in test_mesh_len"
samlurye Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion python/tests/test_python_actors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1515,11 +1515,22 @@ def s(t):
assert r == (0, 1)


class SleepActor(Actor):
@endpoint
async def sleep(self, t: float) -> None:
await asyncio.sleep(t)


@pytest.mark.parametrize("v1", [True, False])
def test_mesh_len(v1: bool):
proc_mesh = spawn_procs_on_fake_host(v1, {"gpus": 12})
s = proc_mesh.spawn("sync_actor", SyncActor)
s = proc_mesh.spawn("sleep_actor", SleepActor)
assert 12 == len(s)
# FIXME: Actually figure out what's going on here.
# Call an endpoint on the actor before the test
# exits. Otherwise we might get a fatal PyGILState_Release
# error.
s.sleep.call(1).get()


class UndeliverableMessageReceiver(Actor):
Expand Down