[monarch][supervision] Increase GetState::<ActorState> default timeout and make it configurable #1474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and make it configurable The current timeout of 1 second for `GetState::<ActorState>` for supervision was causing at least one test to fail. This diff makes the value configurable, and also increases the default to 30 seconds. The failing test now passes. Example test failure that shows the supervision timeout: P1984316048 Differential Revision: [D84232284](https://our.internmc.facebook.com/intern/diff/D84232284/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84232284/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 9, 2025
…t and make it configurable The current timeout of 1 second for `GetState::<ActorState>` for supervision was causing at least one test to fail. This diff makes the value configurable, and also increases the default to 30 seconds. The failing test now passes. Example test failure that shows the supervision timeout: P1984316048 Differential Revision: [D84232284](https://our.internmc.facebook.com/intern/diff/D84232284/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84232284/)! ghstack-source-id: 315062680 Pull Request resolved: #1474
meta-cla
bot
added
the
CLA Signed
…ault timeout and make it configurable" The current timeout of 1 second for `GetState::<ActorState>` for supervision was causing at least one test to fail. This diff makes the value configurable, and also increases the default to 30 seconds. The failing test now passes. Example test failure that shows the supervision timeout: P1984316048 Differential Revision: [D84232284](https://our.internmc.facebook.com/intern/diff/D84232284/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84232284/)! [ghstack-poisoned]
samlurye
added a commit
that referenced
this pull request
Oct 9, 2025
…t and make it configurable Pull Request resolved: #1474 The current timeout of 1 second for `GetState::<ActorState>` for supervision was causing at least one test to fail. This diff makes the value configurable, and also increases the default to 30 seconds. The failing test now passes. Example test failure that shows the supervision timeout: P1984316048 ghstack-source-id: 315174069 Differential Revision: [D84232284](https://our.internmc.facebook.com/intern/diff/D84232284/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84232284/)!
|
This pull request has been merged in df1231d. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
…ble (meta-pytorch#1474) Summary: Pull Request resolved: meta-pytorch#1474 The current timeout of 1 second for `GetState::<ActorState>` for supervision was causing at least one test to fail. This diff makes the value configurable, and also increases the default to 30 seconds. The failing test now passes. Example test failure that shows the supervision timeout: P1984316048 ghstack-source-id: 315174069 Reviewed By: mariusae Differential Revision: D84232284 fbshipit-source-id: 4a56b45e4d0d828602883a68dd57bc044639b4dd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The current timeout of 1 second for
GetState::<ActorState>for supervision was causing at least one test to fail. This diff makes the value configurable, and also increases the default to 30 seconds. The failing test now passes.Example test failure that shows the supervision timeout: P1984316048
Differential Revision: D84232284
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!