[monarch] extension: make CodeSyncMeshClient ActorMesh version polymorphic #1482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rphic This uses shimming to accept both v0 and v1 proc meshes when constructing a codesync client. Differential Revision: [D84284336](https://our.internmc.facebook.com/intern/diff/D84284336/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84284336/)! [ghstack-poisoned]
This was referenced Oct 9, 2025
mariusae
added a commit
that referenced
this pull request
Oct 9, 2025
…rphic This uses shimming to accept both v0 and v1 proc meshes when constructing a codesync client. Differential Revision: [D84284336](https://our.internmc.facebook.com/intern/diff/D84284336/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84284336/)! ghstack-source-id: 315208373 Pull Request resolved: #1482
meta-cla
bot
added
the
CLA Signed
…sion polymorphic" This uses shimming to accept both v0 and v1 proc meshes when constructing a codesync client. Differential Revision: [D84284336](https://our.internmc.facebook.com/intern/diff/D84284336/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84284336/)! [ghstack-poisoned]
mariusae
added a commit
that referenced
this pull request
Oct 9, 2025
…rphic Pull Request resolved: #1482 This uses shimming to accept both v0 and v1 proc meshes when constructing a codesync client. Differential Revision: [D84284336](https://our.internmc.facebook.com/intern/diff/D84284336/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D84284336/)! ghstack-source-id: 315276133
|
This pull request has been merged in d1c5ea4. |
AlirezaShamsoshoara
pushed a commit
to AlirezaShamsoshoara/monarch
that referenced
this pull request
Oct 30, 2025
…a-pytorch#1482) Summary: Pull Request resolved: meta-pytorch#1482 This uses shimming to accept both v0 and v1 proc meshes when constructing a codesync client. ghstack-source-id: 315276133 Reviewed By: colin2328 Differential Revision: D84284336 fbshipit-source-id: 637a4e9101da2d074f982227c1f6b967d49bcbe2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This uses shimming to accept both v0 and v1 proc meshes when constructing a codesync client.
Differential Revision: D84284336
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!