[provenance] persist selected state for clicked line and corresponding mapped lines #152
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context & User Journey
While using the provenance highlight view to check for the code mappings, currently we have the highlights on when hovering over the line, and off whenever the mouse moves out of the line.
When the source codes are non-trivial for certain generated code, the ops from pre-grad / post-grad graphs might span across more than 1 screen view. When user moves mouse over those 2 panes and want to see all the source ops by scrolling, the highlight will be gone and it gets difficult to see all the related nodes.
Also, when user moves mouse out of the window to check model code from code editors or do some other actions, the highlight will also be gone and we lose sight of the mapping info, they have to move the mouse back into the window exactly on previously hovered over line to get back the info, because otherwise the view will be scrolled to other lines when the mouse moves across other lines even only for a short moment.
This PR
In the PR, I'm adding the "selected" state besides "highlight". The user journey would be like: