Skip to content

Conversation

sevenEng
Copy link

Context & User Journey

While using the provenance highlight view to check for the code mappings, currently we have the highlights on when hovering over the line, and off whenever the mouse moves out of the line.

When the source codes are non-trivial for certain generated code, the ops from pre-grad / post-grad graphs might span across more than 1 screen view. When user moves mouse over those 2 panes and want to see all the source ops by scrolling, the highlight will be gone and it gets difficult to see all the related nodes.

Also, when user moves mouse out of the window to check model code from code editors or do some other actions, the highlight will also be gone and we lose sight of the mapping info, they have to move the mouse back into the window exactly on previously hovered over line to get back the info, because otherwise the view will be scrolled to other lines when the mouse moves across other lines even only for a short moment.

This PR

In the PR, I'm adding the "selected" state besides "highlight". The user journey would be like:

  • when user clicks certain line, that line and all mapped lines will enter "selected" state. This "selected" state will stay regardless of user's mouse movement, allowing user to browse and do other inspections.
  • while any line is in "selected" state, we won't do highlight on hovered lines, to prevent the view from scrolling away from current focus
  • if click any already selected line (original clicked or any mapped), we'll get out of the "selected" state, highlighting and scrolling will be enabled again

@meta-cla meta-cla bot added the cla signed label Sep 30, 2025
@yushangdi yushangdi self-requested a review September 30, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants