Refactor CompileDirectoryEntry, print size #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
ezyang
added a commit
that referenced
this pull request
Sep 2, 2024
Fixes https://github.com/pytorch/pytorch/issues/134301 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: 29c22b4 ghstack-comment-id: 2324862517 Pull Request resolved: #64
|
cc @Chillee |
jamesjwu
approved these changes
Sep 2, 2024
|
You might have some trouble with third-party/ when you check this in because human_bytes isn't in our internal Cargo.toml(so idk if it has deps that are incompatible with existing ones). But hopefully it should be fine since it seems like a simple enough library |
ezyang
added a commit
that referenced
this pull request
Sep 3, 2024
Fixes https://github.com/pytorch/pytorch/issues/134301 Signed-off-by: Edward Z. Yang <[email protected]> ghstack-source-id: d9d623d ghstack-comment-id: 2324862517 Pull Request resolved: #64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Signed-off-by: Edward Z. Yang [email protected]