Add support for Write Dist #3347
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78749760 |
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: meta-pytorch#3347 Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
108055c to
ba4fb07
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 23, 2025
Summary: Pull Request resolved: meta-pytorch#3347 Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
ba4fb07 to
18d0ea2
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 23, 2025
Summary: https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
18d0ea2 to
31a2fd4
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 24, 2025
Summary: https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
31a2fd4 to
dc50617
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 24, 2025
Summary: https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
dc50617 to
e6160f9
Compare
kausv
force-pushed
the
export-D78749760
branch
from
e6160f9 to
2b94fe1
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 29, 2025
Summary: https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
2b94fe1 to
cc35666
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 30, 2025
Summary: X-link: meta-pytorch#3347 https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Differential Revision: D78749760
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 30, 2025
Summary: X-link: meta-pytorch#3347 https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
cc35666 to
676eca9
Compare
kausv
force-pushed
the
export-D78749760
branch
from
676eca9 to
742b80e
Compare
kausv
added a commit
to kausv/torchrec
that referenced
this pull request
Sep 30, 2025
Summary: X-link: meta-pytorch#3347 https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Reviewed By: emlin, EddyLXJ Differential Revision: D78749760
Summary: X-link: meta-pytorch#3347 https://docs.google.com/document/d/1N4Q8tdFRVB_qj2vbfadEVmJ-tHolBqL5QiCxa5I8zNk Create Embedding Write Dist. An ability to update individual embedding of a specific feature ID. For now, this is implemented only for KVZCH compute kernel with RW sharding. If any other sharding or kernel tries to call write, an exception will be thrown. Reviewed By: emlin, EddyLXJ Differential Revision: D78749760
kausv
force-pushed
the
export-D78749760
branch
from
742b80e to
c92ca52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D78749760