Intuitionize section "Decimal arithmetic (cont.)" #5052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to match set.mm.
Stated as in set.mm. The proof is the set.mm proof with some small changes for differences in modulus theorems.
Stated as in set.mm. The proof is the set.mm proof with minor changes for differences in modulus theorems.
This is to match current set.mm naming.
This is to match current set.mm naming.
Stated as in set.mm. The proof had to be loaded and saved in mmj2 but is otherwise unchanged from the set.mm proof.
jkingdon
changed the title
avekens
reviewed
Oct 17, 2025
avekens
reviewed
Oct 17, 2025
avekens
reviewed
Oct 17, 2025
This is in set.mm and iset.mm and the change is to make the comment better reflect what the theorem says.
We don't need it yet and the name seems off (what is negative here?) or at least unexplained.
avekens
approved these changes
Oct 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these proofs need no changes. A few need a few small changes to the proof, but none to the result.
The pull request also contains several renames so it might be easier to review commit-by-commit.