Use node16 #2108
Use node16 #2108
Conversation
|
I have fixed it @jakebailey :) |
|
To be clear this is fine, but I probably should have suggested just using nodenext |
If you want, I can open another PR |
| @@ -1,5 +1,5 @@ | |||
| import { parse, type Value, type Node } from "kdljs"; | |||
| import type { Enum, Event, Property, Interface, WebIdl } from "./types"; | |||
| import type { Enum, Event, Property, Interface, WebIdl } from "./types.js"; | |||
There was a problem hiding this comment.
Too late but this should really be d.ts
There was a problem hiding this comment.
No, definitely not; this is correct.
There was a problem hiding this comment.
Note that the PR moved the file to .ts; you can't import a .d.ts file straight up like that without also enabling flags that allow importing TS files.
| @@ -1,4 +1,4 @@ | |||
| import * as Browser from "./types"; | |||
| import * as Browser from "./types.js"; | |||
| } from "bcd-idl-mapper"; | ||
| import api from "bcd-idl-mapper"; | ||
| import * as Browser from "../types"; | ||
| import * as Browser from "../types.js"; |
If you do I'll approve it; node16 is likely going to be deprecated in 6.0. |
Split #2104