Skip to content

Introduce CSSStyleDeclarationBase #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+104 −42
Open

Introduce CSSStyleDeclarationBase #2174

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f70944
Introduce CSSStyleDeclarationBase
saschanaz Sep 30, 2025
5c80179
replace *Properties with *Declaration
saschanaz Sep 30, 2025
b95a6b5
augment test
saschanaz Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions baselines/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4821,7 +4821,7 @@ interface CSSFontFaceRule extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSFontFaceRule/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -4991,7 +4991,7 @@ interface CSSKeyframeRule extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSKeyframeRule/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -5326,7 +5326,7 @@ interface CSSNestedDeclarations extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSNestedDeclarations/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -5440,7 +5440,7 @@ declare var CSSNumericValue: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors)
*/
interface CSSPageDescriptors extends CSSStyleDeclaration {
interface CSSPageDescriptors extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin) */
margin: string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-bottom) */
Expand Down Expand Up @@ -5518,7 +5518,7 @@ declare var CSSPerspective: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors)
*/
interface CSSPositionTryDescriptors extends CSSStyleDeclaration {
interface CSSPositionTryDescriptors extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors#instance_properties) */
"align-self": string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors#instance_properties) */
Expand Down Expand Up @@ -5992,7 +5992,7 @@ declare var CSSStartingStyleRule: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration)
*/
interface CSSStyleDeclaration {
interface CSSStyleDeclarationBase {
/**
* The **`cssText`** property of the CSSStyleDeclaration interface returns or sets the text of the element's **inline** style declaration only.
*
Expand Down Expand Up @@ -6044,12 +6044,15 @@ interface CSSStyleDeclaration {
[index: number]: string;
}

interface CSSStyleDeclaration extends CSSStyleProperties {
}

declare var CSSStyleDeclaration: {
prototype: CSSStyleDeclaration;
new(): CSSStyleDeclaration;
};

interface CSSStyleProperties extends CSSStyleDeclaration {
interface CSSStyleProperties extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/accent-color) */
accentColor: string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/align-content) */
Expand Down Expand Up @@ -7414,7 +7417,7 @@ interface CSSStyleRule extends CSSGroupingRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleRule/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
/**
* The **`styleMap`** read-only property of the CSSStyleRule interface returns a StylePropertyMap object which provides access to the rule's property-value pairs.
Expand Down Expand Up @@ -11458,7 +11461,7 @@ interface ElementCSSInlineStyle {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/attributeStyleMap) */
readonly attributeStyleMap: StylePropertyMap;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/style) */
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -37355,7 +37358,7 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/getComputedStyle)
*/
getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleProperties;
getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleDeclaration;
/**
* The **`getSelection()`** method of the Window interface returns the Selection object associated with the window's document, representing the range of text selected by the user or the current position of the caret.
*
Expand Down Expand Up @@ -39457,7 +39460,7 @@ declare function focus(): void;
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/getComputedStyle)
*/
declare function getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleProperties;
declare function getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleDeclaration;
/**
* The **`getSelection()`** method of the Window interface returns the Selection object associated with the window's document, representing the range of text selected by the user or the current position of the caret.
*
Expand Down
25 changes: 14 additions & 11 deletions baselines/ts5.5/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4821,7 +4821,7 @@ interface CSSFontFaceRule extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSFontFaceRule/style)
*/
readonly style: CSSStyleProperties;
readonly style: CSSStyleDeclaration;
}

declare var CSSFontFaceRule: {
Expand Down Expand Up @@ -4989,7 +4989,7 @@ interface CSSKeyframeRule extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSKeyframeRule/style)
*/
readonly style: CSSStyleProperties;
readonly style: CSSStyleDeclaration;
}

declare var CSSKeyframeRule: {
Expand Down Expand Up @@ -5322,7 +5322,7 @@ interface CSSNestedDeclarations extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSNestedDeclarations/style)
*/
readonly style: CSSStyleProperties;
readonly style: CSSStyleDeclaration;
}

declare var CSSNestedDeclarations: {
Expand Down Expand Up @@ -5435,7 +5435,7 @@ declare var CSSNumericValue: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors)
*/
interface CSSPageDescriptors extends CSSStyleDeclaration {
interface CSSPageDescriptors extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin) */
margin: string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-bottom) */
Expand Down Expand Up @@ -5512,7 +5512,7 @@ declare var CSSPerspective: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors)
*/
interface CSSPositionTryDescriptors extends CSSStyleDeclaration {
interface CSSPositionTryDescriptors extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors#instance_properties) */
"align-self": string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors#instance_properties) */
Expand Down Expand Up @@ -5985,7 +5985,7 @@ declare var CSSStartingStyleRule: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration)
*/
interface CSSStyleDeclaration {
interface CSSStyleDeclarationBase {
/**
* The **`cssText`** property of the CSSStyleDeclaration interface returns or sets the text of the element's **inline** style declaration only.
*
Expand Down Expand Up @@ -6037,12 +6037,15 @@ interface CSSStyleDeclaration {
[index: number]: string;
}

interface CSSStyleDeclaration extends CSSStyleProperties {
}

declare var CSSStyleDeclaration: {
prototype: CSSStyleDeclaration;
new(): CSSStyleDeclaration;
};

interface CSSStyleProperties extends CSSStyleDeclaration {
interface CSSStyleProperties extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/accent-color) */
accentColor: string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/align-content) */
Expand Down Expand Up @@ -7407,7 +7410,7 @@ interface CSSStyleRule extends CSSGroupingRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleRule/style)
*/
readonly style: CSSStyleProperties;
readonly style: CSSStyleDeclaration;
/**
* The **`styleMap`** read-only property of the CSSStyleRule interface returns a StylePropertyMap object which provides access to the rule's property-value pairs.
*
Expand Down Expand Up @@ -11448,7 +11451,7 @@ interface ElementCSSInlineStyle {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/attributeStyleMap) */
readonly attributeStyleMap: StylePropertyMap;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/style) */
readonly style: CSSStyleProperties;
readonly style: CSSStyleDeclaration;
}

interface ElementContentEditable {
Expand Down Expand Up @@ -37332,7 +37335,7 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/getComputedStyle)
*/
getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleProperties;
getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleDeclaration;
/**
* The **`getSelection()`** method of the Window interface returns the Selection object associated with the window's document, representing the range of text selected by the user or the current position of the caret.
*
Expand Down Expand Up @@ -39434,7 +39437,7 @@ declare function focus(): void;
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/getComputedStyle)
*/
declare function getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleProperties;
declare function getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleDeclaration;
/**
* The **`getSelection()`** method of the Window interface returns the Selection object associated with the window's document, representing the range of text selected by the user or the current position of the caret.
*
Expand Down
25 changes: 14 additions & 11 deletions baselines/ts5.6/dom.generated.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4821,7 +4821,7 @@ interface CSSFontFaceRule extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSFontFaceRule/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -4991,7 +4991,7 @@ interface CSSKeyframeRule extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSKeyframeRule/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -5326,7 +5326,7 @@ interface CSSNestedDeclarations extends CSSRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSNestedDeclarations/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -5440,7 +5440,7 @@ declare var CSSNumericValue: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors)
*/
interface CSSPageDescriptors extends CSSStyleDeclaration {
interface CSSPageDescriptors extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin) */
margin: string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPageDescriptors#margin-bottom) */
Expand Down Expand Up @@ -5518,7 +5518,7 @@ declare var CSSPerspective: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors)
*/
interface CSSPositionTryDescriptors extends CSSStyleDeclaration {
interface CSSPositionTryDescriptors extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors#instance_properties) */
"align-self": string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSPositionTryDescriptors#instance_properties) */
Expand Down Expand Up @@ -5992,7 +5992,7 @@ declare var CSSStartingStyleRule: {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleDeclaration)
*/
interface CSSStyleDeclaration {
interface CSSStyleDeclarationBase {
/**
* The **`cssText`** property of the CSSStyleDeclaration interface returns or sets the text of the element's **inline** style declaration only.
*
Expand Down Expand Up @@ -6044,12 +6044,15 @@ interface CSSStyleDeclaration {
[index: number]: string;
}

interface CSSStyleDeclaration extends CSSStyleProperties {
}

declare var CSSStyleDeclaration: {
prototype: CSSStyleDeclaration;
new(): CSSStyleDeclaration;
};

interface CSSStyleProperties extends CSSStyleDeclaration {
interface CSSStyleProperties extends CSSStyleDeclarationBase {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/accent-color) */
accentColor: string;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/CSS/align-content) */
Expand Down Expand Up @@ -7414,7 +7417,7 @@ interface CSSStyleRule extends CSSGroupingRule {
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/CSSStyleRule/style)
*/
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
/**
* The **`styleMap`** read-only property of the CSSStyleRule interface returns a StylePropertyMap object which provides access to the rule's property-value pairs.
Expand Down Expand Up @@ -11458,7 +11461,7 @@ interface ElementCSSInlineStyle {
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/attributeStyleMap) */
readonly attributeStyleMap: StylePropertyMap;
/** [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLElement/style) */
get style(): CSSStyleProperties;
get style(): CSSStyleDeclaration;
set style(cssText: string);
}

Expand Down Expand Up @@ -37355,7 +37358,7 @@ interface Window extends EventTarget, AnimationFrameProvider, GlobalEventHandler
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/getComputedStyle)
*/
getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleProperties;
getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleDeclaration;
/**
* The **`getSelection()`** method of the Window interface returns the Selection object associated with the window's document, representing the range of text selected by the user or the current position of the caret.
*
Expand Down Expand Up @@ -39457,7 +39460,7 @@ declare function focus(): void;
*
* [MDN Reference](https://developer.mozilla.org/docs/Web/API/Window/getComputedStyle)
*/
declare function getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleProperties;
declare function getComputedStyle(elt: Element, pseudoElt?: string | null): CSSStyleDeclaration;
/**
* The **`getSelection()`** method of the Window interface returns the Selection object associated with the window's document, representing the range of text selected by the user or the current position of the caret.
*
Expand Down
9 changes: 9 additions & 0 deletions inputfiles/patches/cssom.kdl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// CSSStyleDeclaration spec change broke a bunch of DT packages.
// This tries to make existing usages work while still keeping the new
// CSSStyleProperties.

interface CSSStyleDeclaration \
forward=CSSStyleDeclarationBase \
forwardExtends=CSSStyleProperties

interface CSSStyleProperties replaceReference=CSSStyleDeclaration
Loading