Port "Fixed nullish coalesce operator's precedence" #1824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Oct 5, 2025
| // CoalesceExpressionHead: | ||
| // CoalesceExpression | ||
| // BitwiseORExpression | ||
| OperatorPrecedenceCoalesce = OperatorPrecedenceLogicalOR |
There was a problem hiding this comment.
Alternatively, I could make the OperatorPrecedenceCoalesce lower than OperatorPrecedenceLogicalOR and then handle that change from Strada in parseBinaryExpressionRest and its computation of consumeCurrentOperator (and maybe in some other places too). cc @weswigham
Andarist
commented
Oct 5, 2025
| case ast.OperatorPrecedenceAssignment: | ||
| // assignment is right-associative | ||
| leftPrec = ast.OperatorPrecedenceLeftHandSide | ||
| case ast.OperatorPrecedenceCoalesce: |
There was a problem hiding this comment.
I had to remove it because it would now be a duplicate case - but it seems that with the current logic I don't even have to move this code anywhere as nothing has regressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#61372