Port "Add support for import defer proposal"
#1826
Open
+845
−2,396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= <[email protected]>
Co-authored-by: =?UTF-8?q?Nicol=C3=B2=20Ribaudo?= <[email protected]>
jakebailey
reviewed
Oct 5, 2025
| get isTypeOnly(): boolean | undefined { | ||
| switch (this.kind) { | ||
| case SyntaxKind.ImportSpecifier: | ||
| case SyntaxKind.ImportClause: |
There was a problem hiding this comment.
Should this defer to phaseModifier in some way?
There was a problem hiding this comment.
I have added that at first but then concluded this should closely match up the defined AST shape and ImportClause doesn't have IsTypeOnly property anymore (in Strada it's deprecated). It could be handled here for convenience though. I'll defer (hehe) the decision to you and @andrewbranch
There was a problem hiding this comment.
That's true, though that should come with an update to the ast package as well.
Andarist
force-pushed
the
port/import-defer
branch
from
e17d915 to
fa0d37d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ports microsoft/TypeScript#60757
ports microsoft/TypeScript#61837