-
Notifications
You must be signed in to change notification settings - Fork 448
Update site-get.md #9639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update site-get.md #9639
Conversation
Added a note about a known issue when trying to access a group team site due to previously reported incidents regarding this.
|
Learn Build status updates of commit 4fa338e:
|
| File | Status | Preview URL | Details |
|---|---|---|---|
| api-reference/v1.0/api/site-get.md | Details |
api-reference/v1.0/api/site-get.md
- Line 58, Column 236: [Warning: hard-coded-locale - See documentation]
Link 'https://learn.microsoft.com/en-us/graph/api/site-getbypath?view=graph-rest-1.0' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites. - Line 6, Column 14: [Suggestion: duplicate-descriptions - See documentation]
Attribute 'description' with value 'Retrieve properties and relationships for a site resource.' is duplicated in 'v1.0/api/site-get.md(6,14)', 'v1.0/api/site-getbypath.md(6,14)'. - Line 58, Column 236: [Suggestion: docs-link-absolute - See documentation]
Absolute link 'https://learn.microsoft.com/en-us/graph/api/site-getbypath?view=graph-rest-1.0' will be broken in isolated environments. Replace with a relative link. - Line 58, Column 236: [Suggestion: preserve-view-not-set - See documentation]
You've pinned this link to a specific version of content with the view parameter. It's recommended not to pin a version unless that version is A) not the default view and B) the context is about that version specifically. To proceed with pinning a version add the &preserve-view=true to the URL. Otherwise, remove the view parameter. URL: https://learn.microsoft.com/en-us/graph/api/site-getbypath?view=graph-rest-1.0
For more details, please refer to the build report.
Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
Performed changes as per the warning - replaced the absolute link to get a sharepoint site by path with a relative one.
|
Learn Build status updates of commit 096e3e0: 💡 Validation status: suggestions
api-reference/v1.0/api/site-get.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
api-reference/v1.0/api/site-get.md
Outdated
| ``` | ||
|
|
||
| > [!IMPORTANT] | ||
| > This API has a known issue: when trying to access a group team site using `GET /groups/{group-id}/sites/root`, you may receive a **308 Permanent Redirect** response. If you follow the Location URL in the response header, it will lead to a **401 Unauthorized** error because the redirect targets the SharePoint REST API directly. **This happens when the group team's site has been renamed.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| > This API has a known issue: when trying to access a group team site using `GET /groups/{group-id}/sites/root`, you may receive a **308 Permanent Redirect** response. If you follow the Location URL in the response header, it will lead to a **401 Unauthorized** error because the redirect targets the SharePoint REST API directly. **This happens when the group team's site has been renamed.** | |
| > This API has a known issue: when trying to access a group team site using `GET /groups/{group-id}/sites/root`, you may receive a **308 Permanent Redirect** response. If you follow the Location URL in the response header, it leads to a **401 Unauthorized** error because the redirect targets the SharePoint REST API directly. This happens when the group team's site has been renamed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR approved.
|
Learn Build status updates of commit 1c31ad0: 💡 Validation status: suggestions
api-reference/v1.0/api/site-get.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
|
@tvelosa, what's the known issue ID? I couldn't find it here (https://developer.microsoft.com/en-us/graph/known-issues/?search={ID}). |
|
@Danielabom I only have the internal issue IDs, I don't think an issue has been published in that portal yet |
|
@tvelosam, when will you have the issue ID available? |
Added a note about a known issue when trying to access a group team site due to previously reported incidents regarding this.
Important
Required for API changes:
Add other supporting information, such as a description of the PR changes:
I'm an SE in the Graph API and as per ADO {https://onedrive.visualstudio.com/DevPlat/_workitems/edit/2545215} I'm changing this to reflect the correct behavior reported by PG.
ADD INFORMATION HERE
Important
The following guidance is for Microsoft employees only. Community contributors can ignore this message; our content team will manage the status.
After you've created your PR, expand this section for tips and additional instructions.
#feedback-addressedto the pull request.For more information, see the Content review process summary.