Skip to content

feat: restart minio server on configuration secret update #2490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat: restart minio server on configuration secret update #2490

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions pkg/controller/main-controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1459,6 +1459,36 @@ func (c *Controller) handleSecret(obj interface{}, oldObj interface{}) {
}
}
}

// check if there is tenant using this secret for configuration
tenants, err := c.minioClientSet.MinioV2().Tenants(secret.Namespace).List(context.Background(), metav1.ListOptions{})
if err != nil {
klog.Errorf("Unable to list tenants in namespace %s: %v", secret.Namespace, err)
return
}
if len(tenants.Items) == 1 {
tenant := &tenants.Items[0]
if tenant.HasConfigurationSecret() && tenant.Spec.Configuration.Name == secret.Name {
for _, poolStatus := range tenant.Status.Pools {
if poolStatus.State != miniov2.PoolInitialized {
klog.Infof("Secret '%s/%s' changed, but tenant %s/%s is not fully initialized, not restarting", secret.Namespace, secret.Name, tenant.Namespace, tenant.Name)
return
}
}
configuration, err := c.getTenantConfiguration(context.Background(), tenant)
if err != nil {
klog.Errorf("Unable to get configuration for tenant %s/%s: %v", tenant.Namespace, tenant.Name, err)
return
}
// pick pod from first initialized pool to signal the restart service.
err = c.restartInitializedPool(context.Background(), tenant, tenant.Spec.Pools[0], configuration)
if err != nil {
klog.Errorf("Unable to restart tenant %s/%s: %v", tenant.Namespace, tenant.Name, err)
return
}
klog.Infof("Secret '%s/%s' changed, tenant %s/%s restarted", secret.Namespace, secret.Name, tenant.Namespace, tenant.Name)
}
}
}

// MinIOControllerRateLimiter is a no-arg constructor for a default rate limiter for a workqueue for our controller.
Expand Down