-
Notifications
You must be signed in to change notification settings - Fork 55
Add check run and check suite events #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
b5849a5
to
66c53b9
Compare
2410faf
to
9d2a9ac
Compare
9d2a9ac
to
094e748
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks alright, but i have a couple of comments for completeness sake
repository: repository; | ||
sender: user; | ||
installation: app_installation_event; | ||
} <ocaml field_prefix="check_run_event_"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation says this type also contain an (optional?) organization
check_run: check_run; | ||
repository: repository; | ||
sender: user; | ||
installation: app_installation_event; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be optional?
] <json open_enum> | ||
|
||
type check_run_event = { | ||
action: check_run_action; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with the requested_action
action, this type also has an (optional?) requested_action
field
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the action might also be optional but i'm not sure
repository: repository; | ||
sender: user; | ||
installation: app_installation_event; | ||
} <ocaml field_prefix="check_suite_event_"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same for this one, an organization
field might be there
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The optional enterprise
field is also available
Added two missing webhook events: