Skip to content

Conversation

oscar-chevalier
Copy link

@oscar-chevalier oscar-chevalier commented Sep 29, 2025

Hello,

This PR allows to create drafts from the API.
Documentation: https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#create-a-pull-request
Thank you in advance.

Copy link
Member

@kit-ty-kate kit-ty-kate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That change in itself seems alright (modulo the comment), however as a github-data user, i find it a bit annoying to have the library break for a lot of (most?) users, for such a small change.

Could you at least add the rest of the optional fields so that we at least don't have to change that type again in the foreseeable future?

@oscar-chevalier
Copy link
Author

oscar-chevalier commented Sep 29, 2025

Hello,

Thank you for the review.
Also, according to #184, maintainer_can_modify should be true by default.

Should head_repo be a string option like body?

@kit-ty-kate
Copy link
Member

Should head_repo be a string option like body?

I believe so, yes.

After looking around at #168 and atdgen -v i'm hoping to merge this at the same time as the new Github_v module in github-data so that a future-proof constructor exists somewhere, to avoid more breakages in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants