Fix Concretification/Unification Issue in app
#139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 17, 2025 22:35
… integrated, branch just needs cleanup.
kozross
requested changes
Nov 20, 2025
Comment on lines
+760
to
+766
| -- *** IMPORTANT *** | ||
| -- The *only* purpose of explicit type application arguments is to instantiate a tyvar in the result which is | ||
| -- not determined by any argument. These variables are instantiated after every other argument has been concretified. | ||
| -- | ||
| -- For example, if you have a function | ||
| -- `f :: forall a b c. (a -> b) -> (b -> a) -> b -> Either a c` | ||
| -- Then you will need to supply *ONE* explicit type application to concretify `c`. |
Member
There was a problem hiding this comment.
A few Haddock formatting things:
- Headings should be
= Heading. You can see examples of this withNotes in various bits of Haddocks in this module. - Backticks won't render as code: you want
@.
Easiest way to check your output is to run cabal haddock, then open the generated index.html in your browser.
Comment on lines
+420
to
+422
| -- NOTE/REVIEW: I am not sure if we should fix this up here. I think we shouldn't, b/c we need the unifiables to | ||
| -- conform with the what the instantiations expect from the explicit type applications, but I | ||
| -- could very easily be wrong. |
Member
There was a problem hiding this comment.
Is this still a problem? I think we discussed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the
zipWithM unifymachinery inappwith "structural" (non-BBF-based) machinery for determining the concretification of functions being applied. Adds a few tests to verify the behavior.